kubeflow / training-operator

Distributed ML Training and Fine-Tuning on Kubernetes
https://www.kubeflow.org/docs/components/training
Apache License 2.0
1.62k stars 700 forks source link

Update Dockerfile with python debian image in cmd/initializer_v2/dataset/Dockerfile #2312

Open mani1soni opened 4 weeks ago

mani1soni commented 4 weeks ago

Updated Dockerfile with python debian image for resolving issue :- "Use Debian images for Python components in the Training Operator V2 #2311" in this dockerfile - cmd/initializer_v2/dataset/Dockerfile

What this PR does / why we need it: This PR replaces the docker image from "python:3.11-alpine" to "python:3.11-slim-bookworm". As per the comment #2303.

Which issue(s) this PR fixes This PR Fixes #2311 issue.

coveralls commented 4 weeks ago

Pull Request Test Coverage Report for Build 11554548437

Details


Totals Coverage Status
Change from base Build 11542660312: 0.0%
Covered Lines: 77
Relevant Lines: 77

💛 - Coveralls
google-oss-prow[bot] commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/training-operator/blob/master/OWNERS)~~ [tenzen-y] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
andreyvelich commented 4 weeks ago

/hold

andreyvelich commented 4 weeks ago

@mani1soni Thank you for this! Please can you also update the model initializer script and verify locally that this images is working with HF snapshot download API ?

mani1soni commented 3 weeks ago

@mani1soni Thank you for this! Please can you also update the model initializer script and verify locally that this images is working with HF snapshot download API ?

Sure @andreyvelich, I'll check that.