[fix] Resolve v2alpha API exceptions

kubeflow / training-operator

Distributed ML Training and Fine-Tuning on Kubernetes

https://www.kubeflow.org/docs/components/training

Apache License 2.0

1.62k stars 700 forks source link

[fix] Resolve v2alpha API exceptions #2317

Closed varshaprasad96 closed 3 days ago

varshaprasad96 commented 3 weeks ago

What this PR does / why we need it: Resolve v2alpha API exceptions by adding necessary listType validations.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged): Fixes #

Checklist:

[ ] Docs included if any changes are user facing

coveralls commented 3 weeks ago

Pull Request Test Coverage Report for Build 11963642932

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall first build on reduce/exception at 100.0%

Totals
Change from base Build 11892919348:	100.0%
Covered Lines:	77
Relevant Lines:	77

💛 - Coveralls

tenzen-y commented 3 weeks ago

It seems that we need to regenerate something

varshaprasad96 commented 4 days ago

@tenzen-y Addressed the open comments, could you please take another look and approve? Thank you!

google-oss-prow[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/training-operator/blob/master/OWNERS)~~ [tenzen-y] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment