Closed jlewi closed 4 years ago
Issue-Label Bot is automatically applying the label kind/feature
to this issue, with a confidence of 0.54. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: app homepage, dashboard and code for this bot.
@sarahmaddox suggested not removing the list of samples but instead with each one listing the Kubeflow versions they work with.
/good-first-issue
@sarahmaddox: This request has been marked as suitable for new contributors.
Please ensure the request meets the requirements listed here.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue
command.
@sarahmaddox Is there an easy way to find out what version these sample work with?
I have a quick look on these samples, most of them just point to "Getting Started with Kubeflow" Semantic code search -- > Getting Started with Kubeflow (https://www.kubeflow.org/docs/started/getting-started/) Financial time series --> KUBEFLOW_VERSION=0.2.5 ?? GitHub issue summarization --> v0.4.0-rc.2. MNIST image classification -- > Getting Started with Kubeflow Object detection - cats and dogs -- > Getting Started with Kubeflow PyTorch MNIST --> Getting Started with Kubeflow Ames housing value prediction --> Getting Started with Kubeflow
@texasmichelle and @amygdala Can you help identify the Kubeflow version for each sample?
I should have some time to tackle it week after next. (Most aren't "mine" and I don't know their current status).
The github summarization/pipelines one is mine, and has been updated to work with 0.7. (Note: that's the pipelines
subdir of that example.)
I'd like to jump on this one if possible. To figure out which version works, I'll look at the CONFIG_FILE url and which master branch it points towards. This always worked for me before.
/assign @hefedev
Thanks @hefedev!
@hefedev I've moved this issue to In progress in the doc sprint Kanban board, because the issue is assigned to you. Happy sprinting!
Thank you @sarahmaddox for the opportunity, I submitted my first changes for feedback. I'll get back on this asap.
I'm not sure this should be closed yet? I believe we're still testing many of these examples with the KF 1 RC. @jlewi @sarahmaddox cc @velascoluis, who is helping with this.
Thanks @amygdala that's excellent news. Let's keep this issue as closed, because it originally related to v0.7 and because @hefedev has implemented a solution using Hugo block parameters and the GitHub API.
How about raising another issue for v1.0. If we need to manually override the results from the API, we can do that via the parameters that feed into the block.
Just a note so it doesn't get lost: https://github.com/kubeflow/examples/blob/master/pipelines/mnist-pipelines/mnist_pipeline.py turns out to be broken (in 0.7 too, I believe, given the nature of the probs).
I think Jeremy did create such an issue for 1.0 already; let me confirm.
This page https://www.kubeflow.org/docs/examples/kubeflow-samples/
lists a lot of samples that I don't think are updated for 0.7.
Should we remove samples until they have been updated for 0.7?
Should we add the xgboost_synthetic ?
code_search is pretty stale at this point as are some other samples so we should probably remove that one.
I think @amygdala might have made some updates to github issue summarization recently