Closed thesuperzapper closed 2 weeks ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: thesuperzapper Once this PR has been reviewed and has the lgtm label, please assign animeshsingh for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
@zijianjoy can review this and approve if you think it's an improvement.
I think it's an important change, because right now, users are confused about the Kubeflow on XXXX
distributions, and this PR adds a notice that tells users that these are not "official" from Kubeflow's perspective, they are just their names.
I am supportive of the additional language on distribution names. On the other changes, I am questioning if the community has agreed on the 6 month rule to define legacy distributions. This seems like a policy that needs to be agreed upon before making web site updates.
@jbottum the main feedback from the community call was about the wording of the "distribution name notice", based on that, I have updated it to say "not the only", rather than "not the official":
Also, regarding the 6-month rule, let's discuss that in a separate change, because that wording is currently on the website, and the other changes from this PR are very helpful to new users.
If we are happy with the change I would love to get this merged, so people know that "Kubeflow on AWS" is not the only way to use Kubeflow on AWS (especially now that "Kubeflow on AWS" is no longer maintained).
I am ok with these changes
@andreyvelich based on your comments in the meeting today, I pushed a small update to the PR with the following changes:
v1.8.0
release tags in kubeflow/manifests
rather than linking people to master
(which may not be installable at any specific time).I think, we can merge this PR given our discussions in https://github.com/kubeflow/website/pull/3643#discussion_r1499312788 and https://github.com/kubeflow/website/pull/3643#discussion_r1496665276 /lgtm /assign @kubeflow/kubeflow-steering-committee @juliusvonkohout @james-jwu @zijianjoy
@zijianjoy @james-jwu because this updates the CSS stylesheet, we need a root approver.
This PR should be ready to merge now, if you approve.
NOTE: the DOC check is not actually marked as "required", so it can be merged if approved.
/hold due to https://github.com/kubeflow/website/pull/3693
Closing because we merged https://github.com/kubeflow/website/pull/3693
The changes in this PR:
Kubeflow on <PLATFORM>
is just name, and not the only way to install Kubeflow on that platform.After we merge this, we need to move the
Kubeflow on AWS
distribution to the legacy distribution table, there is an existing PR to do this:Screenshot