kubeflow / website

Kubeflow's public website
Creative Commons Attribution 4.0 International
145 stars 752 forks source link

add "distribution name" notice on "installing kubeflow" + style improvements #3643

Closed thesuperzapper closed 2 weeks ago

thesuperzapper commented 7 months ago

The changes in this PR:

After we merge this, we need to move the Kubeflow on AWS distribution to the legacy distribution table, there is an existing PR to do this:

Screenshot

Installing-Kubeflow-Kubeflow

google-oss-prow[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: thesuperzapper Once this PR has been reviewed and has the lgtm label, please assign animeshsingh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/website/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
thesuperzapper commented 7 months ago

@zijianjoy can review this and approve if you think it's an improvement.

I think it's an important change, because right now, users are confused about the Kubeflow on XXXX distributions, and this PR adds a notice that tells users that these are not "official" from Kubeflow's perspective, they are just their names.

jbottum commented 5 months ago

I am supportive of the additional language on distribution names. On the other changes, I am questioning if the community has agreed on the 6 month rule to define legacy distributions. This seems like a policy that needs to be agreed upon before making web site updates.

thesuperzapper commented 5 months ago

@jbottum the main feedback from the community call was about the wording of the "distribution name notice", based on that, I have updated it to say "not the only", rather than "not the official":

Screenshot 2024-02-06 at 10 13 26

Also, regarding the 6-month rule, let's discuss that in a separate change, because that wording is currently on the website, and the other changes from this PR are very helpful to new users.

If we are happy with the change I would love to get this merged, so people know that "Kubeflow on AWS" is not the only way to use Kubeflow on AWS (especially now that "Kubeflow on AWS" is no longer maintained).

jbottum commented 4 months ago

I am ok with these changes

thesuperzapper commented 4 months ago

@andreyvelich based on your comments in the meeting today, I pushed a small update to the PR with the following changes:

  1. Added "What is Kubeflow?" to before the Kubeflow introduction at the top
    • Linked the "Introduction" and "Architecture" pages more clearly at the top.
  2. Updated the information in the "Raw Kubeflow Manifests":
    • Now links directly to the specific v1.8.0 release tags in kubeflow/manifests rather than linking people to master (which may not be installable at any specific time).
andreyvelich commented 4 months ago

I think, we can merge this PR given our discussions in https://github.com/kubeflow/website/pull/3643#discussion_r1499312788 and https://github.com/kubeflow/website/pull/3643#discussion_r1496665276 /lgtm /assign @kubeflow/kubeflow-steering-committee @juliusvonkohout @james-jwu @zijianjoy

thesuperzapper commented 4 months ago

@zijianjoy @james-jwu because this updates the CSS stylesheet, we need a root approver.

This PR should be ready to merge now, if you approve.

NOTE: the DOC check is not actually marked as "required", so it can be merged if approved.

andreyvelich commented 4 months ago

/hold due to https://github.com/kubeflow/website/pull/3693

thesuperzapper commented 2 weeks ago

Closing because we merged https://github.com/kubeflow/website/pull/3693