search

kubeflow / website

Kubeflow's public website
Creative Commons Attribution 4.0 International
145 stars 752 forks source link

Adding link to events page from top nav #3669

Closed rareddy closed 5 months ago

rareddy commented 5 months ago

Adding "events" page to top nav and also replacing Kubeflow Summit with GSoC reference.

google-oss-prow[bot] commented 5 months ago

Hi @rareddy. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rareddy commented 5 months ago

@thesuperzapper the navigation changes you are recommending in #3667 for the "events" for your review.

thesuperzapper commented 5 months ago

@rareddy I just saw that we have a page for Kubeflow Summit 2024 on CNCF website, which is co-located with KubeCon EU 2024:

Let's use that link and update the info to:

Also, no need to capitalize the location.

thesuperzapper commented 5 months ago

@rareddy sorry to suggest one more change, but after looking at it, I think it will probably look better to only have one "EU" in the title, so something like Kubeflow Summit / KubeCon Europe

After that, it's great, and we will need one of the root approvers to accept it.

thesuperzapper commented 5 months ago

@james-jwu @zijianjoy can you please approve this small website update?

It replaces the old Kubeflow Summit link with the Kubeflow Summit/KubeCon Europe one (which is happening in 6 weeks).

/lgtm

thesuperzapper commented 5 months ago

@rareddy actually we should use a calendar logo for the "events" link, probably just use the same one as the "KubeCon" link.

thesuperzapper commented 5 months ago

Ok, @james-jwu @zijianjoy after that small update it should be ready to approve now.

/lgtm

james-jwu commented 5 months ago

/lgtm /approve

google-oss-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: james-jwu, rareddy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/website/blob/master/OWNERS)~~ [james-jwu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment