kubeflow / website

Kubeflow's public website
Creative Commons Attribution 4.0 International
145 stars 752 forks source link

Added Gsoc Expcted Outcome #3685

Open Ayush9026 opened 4 months ago

Ayush9026 commented 4 months ago

Solve this Issue added GSoC Outcome of all projects https://github.com/kubeflow/website/issues/3673

So GSoC Google reviewers can access all information.

google-oss-prow[bot] commented 4 months ago

Hi @Ayush9026. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
andreyvelich commented 4 months ago

Please can you sign your commit for DCO ?

Ayush9026 commented 4 months ago

@andreyvelich sir signed commit for DCO.

andreyvelich commented 4 months ago

@andreyvelich sir signed commit for DCO.

@Ayush9026 I think, you should sign second commit for both of us. Otherwise, you can try to squash these 2 commits to one and just sign it: git commit -s -m "Added GSOC Expected Outcome"

google-oss-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ayush9026 Once this PR has been reviewed and has the lgtm label, please assign james-jwu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubeflow/website/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
juliusvonkohout commented 4 months ago

Hello, I think it is istio-cni and istio ambient mesh, not just the ambient mesh.

thesuperzapper commented 4 months ago

Personally, I think the descriptions that are already there probably give enough context to prospective students.

We don't want students being scared off because they think they need to implement the entire thing by themselves. Most of your proposed "expected outcomes" claim the project is about solving the overall problem, rather than just participating in some specific way.

For almost all projects, the "expected outcome" is something smaller, like: "you will support the implementation of bigger project yyyyy by delivering xxxxx".

thesuperzapper commented 4 months ago

Also, I am highly suspicious of this PR, as it is clearly trying to hide something (see the strange e -i HEAD~2 addition in the diff, which GitHub can't view).

I am holding for security review.

/hold

Ayush9026 commented 4 months ago

@thesuperzapper sir e -i HEAD~2 is by mistakely i will remove it . I completely understand the need for a thorough security review. Please let me know if there's any additional information or assistance I can provide during this process.

tenzen-y commented 4 months ago

@thesuperzapper sir e -i HEAD~2 is by mistakely i will remove it . I completely understand the need for a thorough security review. Please let me know if there's any additional information or assistance I can provide during this process.

@Ayush9026 I guess that once you squash all commits into one, all DOC errors are resolved.