Closed jdcfd closed 4 months ago
Hi @jdcfd. Thanks for your PR.
I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Thanks @andreyvelich . I added the changes and signed off on the commit.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: andreyvelich, jdcfd
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Based on the discussion on the PR https://github.com/kubeflow/training-operator/pull/2004 , I updated the documentation website pages for the different
*Job
CRs to include a comment about having to disable automatic sidecar injection in some cases, and how to do that.