kubeflow / website

Kubeflow's public website
Creative Commons Attribution 4.0 International
145 stars 752 forks source link

Updated CRs documentation to include comment about istio annotation #3686

Closed jdcfd closed 4 months ago

jdcfd commented 4 months ago

Based on the discussion on the PR https://github.com/kubeflow/training-operator/pull/2004 , I updated the documentation website pages for the different *Job CRs to include a comment about having to disable automatic sidecar injection in some cases, and how to do that.

google-oss-prow[bot] commented 4 months ago

Hi @jdcfd. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jdcfd commented 4 months ago

Thanks @andreyvelich . I added the changes and signed off on the commit.

google-oss-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, jdcfd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[content/en/docs/components/training/OWNERS](https://github.com/kubeflow/website/blob/master/content/en/docs/components/training/OWNERS)~~ [andreyvelich] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment