kubeflow / website

Kubeflow's public website
Creative Commons Attribution 4.0 International
145 stars 752 forks source link

Katib: Add Hyperparameter Tuning Architecture #3688

Closed andreyvelich closed 4 months ago

andreyvelich commented 4 months ago

Related: https://github.com/kubeflow/katib/issues/2255. I added architecture of HP tuning task in Katib. Also, I made changes for docs flow, please let me know what do you think about it.

/assign @tenzen-y @johnugeorge @gaocegege @kubeflow/release-team @diegolovison @hbelmiro @droctothorpe

/hold for review

droctothorpe commented 4 months ago

Looks great! One small nit that is a testament to what an incorrigible pedant I am and therefore should probably just be ignored: the diagram uses CRD for experiments and trials and other custom resources when what's actually being created is a CR, not a CRD. Unfortunately, https://github.com/kubernetes/community/tree/master/icons doesn't provide a CR icon.

droctothorpe commented 4 months ago

Looks you can use an unlabeled CRD icon to reduce confusion: https://github.com/kubernetes/community/tree/master/icons https://github.com/kubernetes/community/blob/master/icons/svg/resources/unlabeled/crd.svg

andreyvelich commented 4 months ago

Looks great! One small nit that is a testament to what an incorrigible pedant I am and therefore should probably just be ignored: the diagram uses CRD for experiments and trials and other custom resources when what's actually being created is a CR, not a CRD. Unfortunately, https://github.com/kubernetes/community/tree/master/icons doesn't provide a CR icon.

It's a good suggestion, thanks for review @droctothorpe! Let me know if you think we can improve it further.

/hold cancel /assign @tenzen-y @johnugeorge @droctothorpe @hbelmiro

google-oss-prow[bot] commented 4 months ago

@droctothorpe: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubeflow/website/pull/3688#pullrequestreview-1903849796): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
google-oss-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, diegolovison, droctothorpe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[content/en/docs/components/katib/OWNERS](https://github.com/kubeflow/website/blob/master/content/en/docs/components/katib/OWNERS)~~ [andreyvelich] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment