Closed andreyvelich closed 4 months ago
Looks great! One small nit that is a testament to what an incorrigible pedant I am and therefore should probably just be ignored: the diagram uses CRD for experiments and trials and other custom resources when what's actually being created is a CR, not a CRD. Unfortunately, https://github.com/kubernetes/community/tree/master/icons doesn't provide a CR icon.
Looks you can use an unlabeled CRD icon to reduce confusion: https://github.com/kubernetes/community/tree/master/icons https://github.com/kubernetes/community/blob/master/icons/svg/resources/unlabeled/crd.svg
Looks great! One small nit that is a testament to what an incorrigible pedant I am and therefore should probably just be ignored: the diagram uses CRD for experiments and trials and other custom resources when what's actually being created is a CR, not a CRD. Unfortunately, https://github.com/kubernetes/community/tree/master/icons doesn't provide a CR icon.
It's a good suggestion, thanks for review @droctothorpe! Let me know if you think we can improve it further.
/hold cancel /assign @tenzen-y @johnugeorge @droctothorpe @hbelmiro
@droctothorpe: changing LGTM is restricted to collaborators
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: andreyvelich, diegolovison, droctothorpe
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Related: https://github.com/kubeflow/katib/issues/2255. I added architecture of HP tuning task in Katib. Also, I made changes for docs flow, please let me know what do you think about it.
/assign @tenzen-y @johnugeorge @gaocegege @kubeflow/release-team @diegolovison @hbelmiro @droctothorpe
/hold for review