search

kubeflow / website

Kubeflow's public website
Creative Commons Attribution 4.0 International
145 stars 752 forks source link

Use a more compatible URL concat way #3704

Open realnumber666 opened 3 months ago

realnumber666 commented 3 months ago

Fixes #3703 , I try to use urljoin in urllib package to provide a more compatible URL concat way in KFP quickstart doc.

google-cla[bot] commented 3 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-oss-prow[bot] commented 3 months ago

Hi @realnumber666. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
google-oss-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: realnumber666 Once this PR has been reviewed and has the lgtm label, please assign neuromage for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[content/en/docs/components/pipelines/OWNERS](https://github.com/kubeflow/website/blob/master/content/en/docs/components/pipelines/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hbelmiro commented 3 months ago

Thank you for this contribution @realnumber666. /lgtm

hbelmiro commented 3 months ago

@realnumber666 can you please edit the PR description to use Fixes https://github.com/kubeflow/website/issues/3703 instead of Based on my issue https://github.com/kubeflow/website/issues/3703. That way GitHub will automatically link this PR to your issue and will automatically close the issue when this PR is closed.

https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

Thank you in advance.

realnumber666 commented 2 months ago

@hbelmiro Done. Thanks for your advice!