search

kubeflow / website

Kubeflow's public website
Creative Commons Attribution 4.0 International
145 stars 752 forks source link

update doc to reflect new version for Azure #3709

Open mosabami opened 2 months ago

mosabami commented 2 months ago

I didnt know how the azure/latest-version tag works so i just hardcoded the latest versions. if someone can explain to me how its able to identify latest version, that would be great.

google-oss-prow[bot] commented 2 months ago

Hi @mosabami. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
google-oss-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mosabami Once this PR has been reviewed and has the lgtm label, please assign 8bitmp3 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[content/en/docs/started/OWNERS](https://github.com/kubeflow/website/blob/master/content/en/docs/started/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rimolive commented 2 months ago

@mosabami The correct way to change AKS distribution to the version you want is changing https://github.com/kubeflow/website/blob/master/layouts/shortcodes/azure/latest-version.html file.

By the way, we are about to reach feature freeze date for Kubeflow 1.9 and we contacted all distribution owners to confirm if they will participate in the distribution testing phase. Can you help us identify the AKS distribution owners and ask them if they will participate in the distribution testing? https://github.com/kubeflow/manifests/issues/2611