search

kubeflow / website

Kubeflow's public website
Creative Commons Attribution 4.0 International
145 stars 752 forks source link

Docs ENV error #3717

Open Kaeldara-ru opened 2 months ago

Kaeldara-ru commented 2 months ago

KATIB_POSTGRESQL_DATABASE - Wrong. In sources Env is KATIB_POSTGRESQL_DB_DATABASE

https://github.com/kubeflow/katib/blob/master/pkg/db/v1beta1/common/const.go

hbelmiro commented 2 months ago

@Kaeldara-ru can you point out where in the docs this is wrong? Also, feel free to send a PR to fix it.

Kaeldara-ru commented 2 months ago

@Kaeldara-ru can you point out where in the docs this is wrong? Also, feel free to send a PR to fix it.

https://github.com/kubeflow/katib/blob/2d308b72c3b4ed6f1365d7c6002a307386a8d252/pkg/db/v1beta1/common/const.go#L43

On this line parse another env. KATIB_POSTGRESQL_DATABASE - not implemented. I'll check releases branches -> current main. All time was KATIB_POSTGRESQL_DB_DATABASE

andreyvelich commented 2 months ago

Thank you for reporting this @Kaeldara-ru! You are right, please can you create a PR to fix this guide ?

andreyvelich commented 2 months ago

cc @kubeflow/wg-automl-leads

Kaeldara-ru commented 2 months ago

https://github.com/kubeflow/website/pull/3720

PR created