kubeflow / website

Kubeflow's public website
Creative Commons Attribution 4.0 International
145 stars 752 forks source link

Fixes: #3717 #3720

Open Kaeldara-ru opened 2 months ago

Kaeldara-ru commented 2 months ago

https://github.com/kubeflow/katib/blob/2d308b72c3b4ed6f1365d7c6002a307386a8d252/pkg/db/v1beta1/common/const.go#L43

On this line parse another env. KATIB_POSTGRESQL_DATABASE - not implemented. I'll check releases branches -> current main. All time was KATIB_POSTGRESQL_DB_DATABASE

Fixes: https://github.com/kubeflow/website/issues/3717

google-oss-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kaeldara-ru Once this PR has been reviewed and has the lgtm label, please assign gaocegege for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[content/en/docs/components/katib/OWNERS](https://github.com/kubeflow/website/blob/master/content/en/docs/components/katib/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
google-oss-prow[bot] commented 2 months ago

Hi @Kaeldara-ru. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
andreyvelich commented 2 months ago

@Kaeldara-ru Thank you for your contribution 🎉

I think, you should add this: Fixes: https://github.com/kubeflow/website/issues/3717 to your PR description as @hbelmiro suggested. Don't need to modify the PR title.

andreyvelich commented 2 months ago

@Kaeldara-ru Please can you sign your commit as described here: https://www.kubeflow.org/docs/about/contributing/#sign-off-your-commits?