Closed andreyvelich closed 4 months ago
/hold for review
This PR should be ready for review. @StefanoFioravanzo @hbelmiro @kubeflow/wg-training-leads Please let me know what do you think about new doc structure?
/lgtm
/assign @StefanoFioravanzo Any feedback from your side ?
Are there any new how-to guides or did you just move them without changes?
Yes, I added a few new docs from Katib GitHub:
I think, our goal should be to keep all docs (users, admins, and developers) in the single place. What do you think about it @kubeflow/wg-training-leads ? In the future, we can try to organize kubeflow.org to fetch doc files from the GitHub repos as we thought before, but it will take time to discuss/implement it.
@StefanoFioravanzo I made your suggested changes, please let me know what do you think.
@andreyvelich so we don't end up with 404 errors (which hurt SEO and confuse users), can you please add redirects for any pages that you have removed/renamed?
You need to update this file: https://github.com/kubeflow/website/blob/master/content/en/_redirects
@andreyvelich so we don't end up with 404 errors (which hurt SEO and confuse users), can you please add redirects for any pages that you have removed/renamed?
You need to update this file: https://github.com/kubeflow/website/blob/master/content/en/_redirects
It's a good point! I will update it.
@StefanoFioravanzo Thanks again for your great review! Do you have any other suggestions for this PR ?
@andreyvelich thank you for putting so much effort on this. I love how we are refactoring these docs. They will become an example for all other WGs.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: andreyvelich
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/hold cancel
Fixes: https://github.com/kubeflow/katib/issues/2314, https://github.com/kubeflow/katib/issues/1672.
I reorganized Katib doc based on our recent discussions.
Still need to finish some docs:
@StefanoFioravanzo Please let me know what do you think about this doc structure.
/assign @StefanoFioravanzo @droctothorpe @kubeflow/wg-training-leads @hbelmiro @droctothorpe @franciscojavierarceo