kubeflow / website

Kubeflow's public website
Creative Commons Attribution 4.0 International
145 stars 752 forks source link

Fix Local Builds + Update: Hugo, MathJax, Mermaid #3725

Closed thesuperzapper closed 2 months ago

thesuperzapper commented 2 months ago

Because Hugo 0.125.0+ does not work (which will break people's ability to develop the website locally), I have put an explanation in the README of how users can downgrade hugo with brew.

This PR changes the behavior of the site to improve performance:

This PR also makes the following updates:

thesuperzapper commented 2 months ago

@james-jwu @andreyvelich @jbottum this PR is small but important for 2 reasons:

  1. Currently, if users follow the "local dev guide" hugo wont work (if they use the latest hugo).
  2. It improves the performance of the website (only load heavy JS packages on the pages we actually use them).

I would appreciate your review.

google-oss-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan, thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/website/blob/master/OWNERS)~~ [terrytangyuan] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment