search

kubeflow / website

Kubeflow's public website
Creative Commons Attribution 4.0 International
145 stars 752 forks source link

feat: Add Francisco as OWNER for Feature Store documentation #3731

Closed franciscojavierarceo closed 1 month ago

franciscojavierarceo commented 2 months ago

I am one of the maintainers of Feast and I'd like to update the documentation here.

So I have proposed to add myself as an OWNER for the Feature Store documentation.

google-oss-prow[bot] commented 2 months ago

Hi @franciscojavierarceo. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
franciscojavierarceo commented 2 months ago

@andreyvelich @woop

franciscojavierarceo commented 1 month ago

@Arhell any update here?

Arhell commented 1 month ago

Sorry, I don't have approval rights

franciscojavierarceo commented 1 month ago

Np I also added a separate PR to add me to the org here: https://github.com/kubeflow/internal-acls/pull/679

woop commented 1 month ago

/approve

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: woop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[content/en/docs/external-add-ons/feature-store/OWNERS](https://github.com/kubeflow/website/blob/master/content/en/docs/external-add-ons/feature-store/OWNERS)~~ [woop] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
franciscojavierarceo commented 1 month ago

@johnugeorge any chance you can review?

rimolive commented 1 month ago

/lgtm

rimolive commented 1 month ago

/verify-owners