kubeflow / website

Kubeflow's public website
Creative Commons Attribution 4.0 International
145 stars 751 forks source link

configure-experiment.md - missing annotation value in yaml example #3735

Closed toschneck closed 1 month ago

toschneck commented 1 month ago

add missing annotation value in yaml example otherwise the apply of the experiment will fail as invalid:

Error from server: error when creating "random.yaml": admission webhook "validator.experiment.katib.kubeflow.org" denied the request: invalid spec.trialTemplate: unable to convert: /spec/template/metadata/sidecar.istio.io~1inject - false to Job, converted template: {"kind":"Job","apiVersion":"batch/v1","metadata":{"creationTimestamp":null},"spec":{"template":{"metadata":{"creationTimestamp":null},"spec":{"containers":[{"name":"training-container","image":"docker.io/kubeflowkatib/pytorch-mnist-cpu:latest","command":["python3","/opt/pytorch-mnist/mnist.py","--epochs=1","--batch-size=16","--lr=test-value","--momentum=test-value"],"resources":{"limits":{"cpu":"500m","memory":"1Gi"}}}],"restartPolicy":"Never","nodeSelector":{"type":"gpu"}}}},"status":{}}
google-oss-prow[bot] commented 1 month ago

Hi @toschneck. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[content/en/docs/components/katib/OWNERS](https://github.com/kubeflow/website/blob/master/content/en/docs/components/katib/OWNERS)~~ [andreyvelich] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment