kubeflow / website

Kubeflow's public website
Creative Commons Attribution 4.0 International
145 stars 751 forks source link

Removed reference to non existing path #3743

Closed rajeeshckr closed 1 month ago

rajeeshckr commented 1 month ago

Looks like platform-agnostic-pns folder seems to be removed in this commit

I hope platform-agnostic is the new one to use.

Also, there was an error with workflow-controller and metadata-envoy-deployment using the same port causing crash loop. I modified the workflow-controller deployment to change the to a non conflicting port.

image
google-oss-prow[bot] commented 1 month ago

Hi @rajeeshckr. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
hbelmiro commented 1 month ago

/ok-to-test

hbelmiro commented 1 month ago

@chensun can you PTAL?

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[content/en/docs/components/pipelines/OWNERS](https://github.com/kubeflow/website/blob/master/content/en/docs/components/pipelines/OWNERS)~~ [chensun] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment