kubeflow / website

Kubeflow's public website
Creative Commons Attribution 4.0 International
145 stars 751 forks source link

Update to pipelines OWNERS #3772

Closed hbelmiro closed 1 week ago

hbelmiro commented 2 weeks ago

Adding myself as a reviewer to pipelines OWNERS.

@chensun do you suggest any other updates for the pipelines OWNERS?

/assign @andreyvelich @chensun

rimolive commented 2 weeks ago

/approve

rimolive commented 2 weeks ago

cc @andreyvelich

thesuperzapper commented 1 week ago

@hbelmiro I warn you that this will result in you being assigned as a reviewer to literally all PRs they get created on the website (because the other sections OWNERS don't define reviewers)

You might want to only add yourself as a reviewer for the sections you actually maintain (e.g. not at the root).

google-oss-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[content/en/docs/components/pipelines/OWNERS](https://github.com/kubeflow/website/blob/master/content/en/docs/components/pipelines/OWNERS)~~ [chensun] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hbelmiro commented 1 week ago

Thank you @thesuperzapper. I removed myself from root.

@rimolive can you take a second look?

hbelmiro commented 1 week ago

/lgtm

google-oss-prow[bot] commented 1 week ago

@hbelmiro: you cannot LGTM your own PR.

In response to [this](https://github.com/kubeflow/website/pull/3772#issuecomment-2186528810): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rimolive commented 1 week ago

/lgtm