kubeflow / website

Kubeflow's public website
Creative Commons Attribution 4.0 International
145 stars 751 forks source link

Update Kubeflow diagrams with Spark Operator and Model Registry #3780

Closed andreyvelich closed 1 week ago

andreyvelich commented 1 week ago

I updated Kubeflow diagrams with Spark Operator and Model Registry, since we already have these components on Kubeflow website.

/assign @kubeflow/wg-data-leads @kubeflow/kubeflow-steering-committee @vikas-saxena02

rimolive commented 1 week ago

/lgtm

tarilabs commented 1 week ago

Thank you so much @andreyvelich

In content/en/docs/started/images/kubeflow-intro-diagram.drawio.svg I would suggest rename the in-parenthesis from: (ML Metadata) to: (Model Metadata)

so to keep the generic scope intended by the parenthesis, and avoid potential confusion with the "MLMD" (library/project).

wdyt ?

thesuperzapper commented 1 week ago

@andreyvelich I agree that we should say "Model Metadata" rather than "ML Metadata" (which is the name of an actual project that we use as a dependency: https://github.com/google/ml-metadata

Also, can you fix the alignment problem on the "Feast" square, it drives me crazy:

Screenshot 2024-06-24 at 15 53 44

vikas-saxena02 commented 1 week ago

great work @andreyvelich you just depicted my precise thoughts here.

/approve

vikas-saxena02 commented 1 week ago

/approve

andreyvelich commented 1 week ago

Sounds good, updated. /assign @tarilabs @thesuperzapper

andreyvelich commented 1 week ago

/approve

google-oss-prow[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, tarilabs, vikas-saxena02

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[content/en/docs/started/OWNERS](https://github.com/kubeflow/website/blob/master/content/en/docs/started/OWNERS)~~ [andreyvelich] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment