search

kubeflow / website

Kubeflow Website
https://www.kubeflow.org
Creative Commons Attribution 4.0 International
149 stars 773 forks source link

Moved multi-user to KFP v2 docs #3786

Closed hbelmiro closed 1 month ago

hbelmiro commented 3 months ago

Resolves: https://github.com/kubeflow/website/issues/3749

cc @chensun

rimolive commented 3 months ago

/lgtm

rimolive commented 3 months ago

/lgtm /approve

rimolive commented 3 months ago

cc @jbottum For some reason this specific PR requested your approval. Can you help us in here?

jbottum commented 3 months ago

sure, but I am not sure I understand it. It looks like just a documentation change. Have the KFP WG leads commented ? are they on PTO ?

hbelmiro commented 3 months ago

@jbottum this PR changes the content/en/_redirects. This file doesn't belong to the pipelines folder. That's why it needs approval from root approvers.

hbelmiro commented 2 months ago

/hold

hbelmiro commented 2 months ago

/unhold

@terrytangyuan can you also take a look? We need a root approver.

hbelmiro commented 2 months ago

@terrytangyuan @jbottum @andreyvelich @james-jwu can one of you guys take a look? We need a root approver.

hbelmiro commented 2 months ago

/hold

hbelmiro commented 2 months ago

/unhold

zijianjoy commented 1 month ago

/approve

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rimolive, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/website/blob/master/OWNERS)~~ [zijianjoy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rimolive commented 1 month ago

/lgtm