kubeguard / guard

🔑 Kubernetes Authentication & Authorization WebHook Server
https://kubeguard.dev
Apache License 2.0
591 stars 81 forks source link

Adding Authz support for Azure #255

Closed krdhruva closed 4 years ago

krdhruva commented 4 years ago

Adding Authz support for Azure for both AKS and ARC scenarios. This PR contains cli, code and doc changes. This implements #237

krdhruva commented 4 years ago

@weinong , @tamalsaha can you please take a look?

tamalsaha commented 4 years ago

@krdhruva , can you please rerun the go mod command? It seems to fail on CI. We use Go 1.14 currently.

krdhruva commented 4 years ago

@tamalsaha are we OK to merge?

tamalsaha commented 4 years ago

@krdhruva , I am done with the review. Please let me know what you think.

krdhruva commented 4 years ago

@tamalsaha I have incorporated all review comments and updated PR.

krdhruva commented 4 years ago

@tamalsaha can you please take a look?

krdhruva commented 4 years ago

@tamalsaha I have resolved all the comments and updated PR. Kindly have a look.

tamalsaha commented 4 years ago

Thanks a lot, @krdhruva for addressing my comments. Do you want me to cut a release?

krdhruva commented 4 years ago

Thanks a lot @tamalsaha for reviewing and merging my PR. Yes, please release a new version with the changes.

tamalsaha commented 4 years ago

Done ! https://github.com/appscode/guard/releases/tag/v0.6.0-rc.0