kubeguard / guard

🔑 Kubernetes Authentication & Authorization WebHook Server
https://kubeguard.dev
Apache License 2.0
591 stars 81 forks source link

Changed azure authz support to use v1beta1 version instead of v1 for SubjectAccessReview #259

Closed Anumita closed 4 years ago

Anumita commented 4 years ago

Making this change as even though we are expecting v1 version of SAR, we are still getting v1beta1 version. Also, in v1beta1 version there is k8s bug where instead of "groups" SAR decodes it as "group". Even though this is fixed in v1, we are not being able to use v1 version. Will be raising a bug on k8s on this regarding how we can use v1 version. Till then as we don't want to explicity call graph every time to get the groups, we are changing to use v1beta1 version so that we can get the groups the user is part of

Signed-off-by: Anumita Shenoy ansheno@microsoft.com

Anumita commented 4 years ago

As mentioned in bug that we raised (https://github.com/kubernetes/kubernetes/issues/91821), we need to set "--authorization-webhook-version=v1" in apiserver to get v1 requests. But this feature is available only in K8s versions 1.17 and above. So for now, we will go with this fix to support the k8s versions under 1.17

Anumita commented 4 years ago

@weinong , @tamalsaha , could you review this PR?

weinong commented 4 years ago

relate to https://github.com/kubernetes/kubernetes/pull/85441