search

kubeguard / guard

🔑 Kubernetes Authentication & Authorization WebHook Server
https://kubeguard.dev
Apache License 2.0
591 stars 81 forks source link

Avoid storing result in cache on checkaccess error #340

Closed Anumita closed 2 years ago

Anumita commented 2 years ago

When checkaccess returns error, we have made change to not store result as denied in the cache since it's not actually a deny and could be a transient http error (like 500, 504 etc).

We are storing the result into cache if the error is not http and also if error code is 429 (too many requests)

weinong commented 2 years ago

is this PR complete? besides, we also want to return distinctive message indicating retry may be needed

Anumita commented 2 years ago

@tamalsaha , we have merged all the PR's we had open. Could you release a new image for guard? :)

Anumita commented 2 years ago

@tamalsaha , we have merged all the PR's we had open. Could you release a new image for guard? :)

Hey @tamalsaha gentle reminder

tamalsaha commented 2 years ago

Just completed :) https://github.com/kubeguard/guard/releases/tag/v0.10.0

Anumita commented 2 years ago

Just completed :) https://github.com/kubeguard/guard/releases/tag/v0.10.0

Thanks a lot!

tamalsaha commented 2 years ago

Thanks for the continued contribution to this project!