Make retrable http client's retry count configurable in Azure auth provider

kubeguard / guard

🔑 Kubernetes Authentication & Authorization WebHook Server

https://kubeguard.dev

Apache License 2.0

590 stars 81 forks source link

Make retrable http client's retry count configurable in Azure auth provider #370

Closed bingosummer closed 1 year ago

bingosummer commented 1 year ago

We've seen issues where this "get metadata" step times out when there are transient network issues. https://github.com/kubeguard/guard/pull/353 added retrable http client. The 3 retry attempts can partially fix it, but in some cases, it still timeouts after 3 retries.

We need to make the retry attempts configurable.

bingosummer commented 1 year ago

@weinong @Anumita @AzureMarker could you please have a review? Thanks!

bingosummer commented 1 year ago

@tamalsaha could you please approve and merge the PR? Thanks!