Refactor and improve UT for PoP token verifier

kubeguard / guard

🔑 Kubernetes Authentication & Authorization WebHook Server

https://kubeguard.dev

Apache License 2.0

590 stars 81 forks source link

Closed nehaPrakash98 closed 1 year ago

nehaPrakash98 commented 1 year ago

The goal of this PR is to improve the test coverage. All of the happy path and error cases (where feasible) are covered by unit tests.
In order to improve the readability of the tests, the test code that makes the test PoP tokens has been refactored. The existing code was hard to extend for new scenarios and hard to follow. The new code uses a builder pattern to create the tokens.

Previous test coverage was ~80% Current test coverage is 91.5%

AzureMarker commented 1 year ago

julienstroheker commented 1 year ago

@weinong are you able to trigger BUILD to validates the UT on this PR please ?

julienstroheker commented 1 year ago

@nehaPrakash98 please check the DCO