search

kubemq-io / kubemq-CSharp

C# Library for KubeMQ server
MIT License
30 stars 8 forks source link

Add additional TFM with less dependencies #32

Closed thompson-tomo closed 6 months ago

thompson-tomo commented 6 months ago

Describe the feature.

I want my application's and libraries to be as small as possible and the minimum amount of dependencies.

Is your feature related to a problem?

Additional dependencies are being added to my projects.

Describe the requested feature

When the framework is able to natively provide a dependency ie System.* that should be utilised rather than an explicit dependency. This will be the case for the net 5+ TFM.

Describe alternatives you've considered

Accept the additional dependencies

Additional Context

No response

kubemq commented 6 months ago

Hi, Not sure what you are proposing.

thompson-tomo commented 6 months ago

I will submit a PR in the coming days. But effectively I will add a new TFM (net 5) and by adding the new framework explicit dependencies for the below can be removed (last one to be checked):

kubemq commented 6 months ago

Bear in mind that this sdk should support .net framework as well

thompson-tomo commented 6 months ago

Not an issue with the approach & changes have been suggested via #33

kubemq commented 6 months ago

Check out version 1.7.2. I have set the .net 5 along with other targets

thompson-tomo commented 6 months ago

@kubemq i have just merged master in to main, so please have a look as 1.7.2 still doesn't have benefit which is less dependencies. Hence my PR is ready for merge.