search

kubemq-io / kubemq-CSharp

C# Library for KubeMQ server
MIT License
30 stars 8 forks source link

#32 Add conditional depenencies to reduce dependency graph #33

Closed thompson-tomo closed 5 months ago

thompson-tomo commented 5 months ago

Added in conditional logic for dependencies so that 3 can be removed from the dependency graph when targeting net5 or higher

Closes #32

kubemq commented 5 months ago

@thompson-tomo , I have to revert this merge because it breaks the code. using System.Threading.Tasks.Dataflow is needed .

thompson-tomo commented 5 months ago

@kubemq it is provided by the framework so u don't need an explicit dependency on it

thompson-tomo commented 5 months ago

Ahh, i worked out the issue. it looks like i did a typo after i tested which resulted in the condition not working as expected. Hence have resubmitted it.

kubemq commented 5 months ago

We are going to replace the BlockBuffer call with queue so no need for this package at all

On Mon, Apr 29, 2024 at 2:18 PM James Thompson @.***> wrote:

Ahh, i worked out the issue. it looks like i did a typo after i tested which resulted in the condition not working as expected. Hence have resubmitted it.

— Reply to this email directly, view it on GitHub https://github.com/kubemq-io/kubemq-CSharp/pull/33#issuecomment-2082457945, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK5WGXFMZ6WDOO32OFE4HZTY7YUCFAVCNFSM6AAAAABG5ADTVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBSGQ2TOOJUGU . You are receiving this because you were mentioned.Message ID: @.***>