[Feature Request] Restructuring and introducion best practices for the helm chart - Githubissues

kubeovn / kube-ovn

A Bridge between SDN and Cloud Native (Project under CNCF)

https://kubeovn.github.io/docs/stable/en/

Apache License 2.0

1.93k stars 438 forks source link

[Feature Request] Restructuring and introducion best practices for the helm chart #4330

Open oujonny opened 1 month ago

oujonny commented 1 month ago

Description

Currently, the helm chart is quite a mess in my point of view. Mostly it is about the structure and naming of all the values.

I suggest the following improvements:

define all variables in lowerCamelCase
combine all configuration-related vars into one map (to access later for example ".Values.config.logDir" )
introduce variables for all the Kubernetes-related things for each component (image, labels, annotations, strategy, affinities etc..)
Document the variables with helm-docs

In general, I'm a big fan of the charts from Bitnami or Grafana for example.

I'm open to contribute those improvements with a PR :)

Who will benefit from this feature?

Everyone who uses helm for the installation.

Anything else?

No response

oilbeater commented 1 month ago

@oujonny Thanks, looking forward to you contribution!