kubereboot / kured

Kubernetes Reboot Daemon
https://kured.dev
Apache License 2.0
2.18k stars 202 forks source link

Migrate to kubereboot/kured #633

Closed dholbach closed 1 year ago

dholbach commented 2 years ago

As we are now a CNCF Sandbox project, we want to move to our new home kubereboot/kured, but we want to do it sensibly.

Items likely involved are:

dholbach commented 2 years ago

https://github.com/cncf/sandbox/issues/208

evrardjp commented 2 years ago

I was thinking about something along those lines:

  1. [x] Announce changes in github README, mentioning that there might be unavailability time of helm charts/container images. @evrardjp https://github.com/weaveworks/kured/pull/637
  2. [x] Migrate repo to kubereboot/kured @dholbach
  3. [x] Change gh actions to push towards ghcr @dholbach https://github.com/kubereboot/kured/pull/644
  4. [x] Decide what to do with the old images: Reupload, or be clear that the legacy images are hosted on weaveworks' docker hub. Document decision in issue. all current maintainers cncf/sandbox#249
  5. [x] Reupload images @hiddeco
  6. [x] Decide what to do with helm: Now that we have a different org, it allows us to have a different repo for helm charts, which might be easier. @ckotzbauer #https://github.com/weaveworks/kured/issues/640
  7. [x] Do what's necessary for helm being available @evrardjp
  8. [x] Ensure helm is using the new images @evrardjp
  9. [ ] Reconfigure github repo with CNCF guidelines @dholbach
  10. [ ] Update documentation
  11. [ ] Produce release to exercise gh actions behaviour. TBD
  12. [ ] Announce move's end. https://github.com/weaveworks/kured/issues/635 @dholbach
dholbach commented 2 years ago

It appears that we have published everything from 1.8.2 onwards to GHCR, so that'd be support for k8s >= 1.20,

evrardjp commented 2 years ago

We'll check what are the fate of the ghcr images when we migrate the ownership -- if they move with the transfer of ownership, that would be quite a benefit :)

evrardjp commented 2 years ago

Updated post https://github.com/weaveworks/kured/issues/633#issuecomment-1250692507 with more details, and mentioning people. What I am eager to see is a view on how we'll do the helm chart going forward. If we plan to stay the same, or if we allow ourselves to have a separate repo, which might be favorable (and more clear for contributors). I will link to an issue for this.

dholbach commented 2 years ago

I was just informed that the repo move will not happen before tomorrow (Tue, 20th Sept).

dholbach commented 2 years ago

I just invited @morancj to be owner of the kubereboot org to be able to perform the repo transfer.

dholbach commented 2 years ago

We are still using the weave-ghcr-bot (as outside collaborator) to not break the build. We will have to create a new bot account I assume.

We also have davidkarlsen as outside collaborator - he got triage access a longer while ago when we worked on kured together. We should discuss this as part of our new governance.

ckotzbauer commented 2 years ago

fyi, the helm-chart-repo is broken since the transfer, so we have to move the chart to its new location asap.

kbhalaki commented 2 years ago

what is the new location of the chart?

ckotzbauer commented 2 years ago

@kbhalaki For now https://kubereboot.github.io/kured When its moved to its own repo, it will change again (I think to https://kubereboot.github.io/charts)

kbhalaki commented 2 years ago

@ckotzbauer above link shows to run repo add command with broken link:

helm repo add kured https://weaveworks.github.io/kured/

dholbach commented 2 years ago

We are in the process of moving right now. It will take a little while until this is resolved.

cesarca commented 2 years ago

Any temporary solution? Right now this problem is affecting my work team.

dholbach commented 2 years ago

Images are available from GHCR https://github.com/weaveworks/kured/pkgs/container/kured

kbhalaki commented 2 years ago

@dholbach Any url for the chart?

dholbach commented 2 years ago

We are working on bringing the chart repository back.

dholbach commented 2 years ago

For more context: Weaveworks kindly donated the kured project to the Cloud Native Computing Foundation, which accepted us as a project a week back. :tada: This will ensure that kured project will live in a vendor-neutral home.

For us this is a big and exciting move. Please hang tight and be patient - we are working on this as fast as we can.

Please also join us on CNCF Slack in #kured. Contributions to the project are very welcome as well! We want our team to grow!

kingdonb commented 2 years ago

I noticed the issue on my prometheus dashboard (starting about 6 hours ago) and I replaced the spec.url in my HelmRepository with this one:

(deleted)

The trouble is cleared for me, if I've understood the whole thread ~then everything will be moving again once more before the process is finished.~ that's done!

Perhaps I can help contribute something upstream so that we can publish OCI Charts next ๐Ÿ‘ I see that we're using:

helm/chart-releaser-action@v1.1.0 (here) so if I can do anything to move along this issue, I will:

Also, ๐ŸŒฎ ๐ŸŽ‰ about Kured joining the CNCF!

cesarca commented 2 years ago

I noticed the issue on my prometheus dashboard (starting about 6 hours ago) and I replaced the spec.url in my HelmRepository with this one:

---
apiVersion: source.toolkit.fluxcd.io/v1beta1
kind: HelmRepository
metadata:
  name: kured
  namespace: flux-system
spec:
  interval: 4h0m0s
  url: https://kubereboot.github.io/kured/

The trouble is cleared for me, if I've understood the whole thread then everything will be moving again once more before the process is finished.

Perhaps I can help contribute something upstream so that we can publish OCI Charts next ๐Ÿ‘ I see that we're using:

helm/chart-releaser-action@v1.1.0 (here) so if I can do anything to move along this issue, I will:

Also, ๐ŸŒฎ ๐ŸŽ‰ about Kured joining the CNCF!

@kingdonb use: spec: interval: 4h0m0s url: https://kubereboot.github.io/charts

cesarca commented 2 years ago

Hi, the new url: https://kubereboot.github.io/charts is operational ๐ŸŽ‰

kingdonb commented 2 years ago

Super, confirmed I am picking up the new chart version 4.0.1 from there ๐Ÿ‘

cesarca commented 2 years ago

Super, confirmed I am picking up the new chart version 4.0.1 from there ๐Ÿ‘

Nice ๐Ÿ‘๐Ÿผ

evrardjp commented 2 years ago

Perhaps I can help contribute something upstream so that we can publish OCI Charts next ๐Ÿ‘ I see that we're using:

helm/chart-releaser-action@v1.1.0 (here) so if I can do anything to move along this issue, I will:

That would be lovely! I don't use that, but it makes sense to me. Maybe ckotzbauer would love it too :)

evrardjp commented 2 years ago

Side note, another version will come, with our ghcr images ;) Still, happy to read that 4.0.1 works.

evrardjp commented 2 years ago

Sorry if I didn't communicate here when the charts started to be online, I was deep into the builds.... Anyway, I hope the dust will settle now, and we can improve all together :)

kdandersen commented 2 years ago

Hi, the new url: https://kubereboot.github.io/charts is operational ๐ŸŽ‰

Hi @cesarca

When trying to use the new Helm chart location I get the following error with a reference back to the original Weaveworks repo.

image

I.e. I believe the index.yaml still has reference to the no longer existing Waeaveworks repo.

Kind regards Kim

dholbach commented 2 years ago

Can you update to 4.0.1?

kdandersen commented 2 years ago

A manual delete of all files the Helm Cache folder solved the issue.

Thanks K

mkemmerz commented 2 years ago

As the helm chart 3.0.0 was just recently released one question. What is the difference to 4.0.x? Was this done simply for the migration or any breaking changes from v3 to v4?

evrardjp commented 2 years ago

The breaking change for deployers is the fact the URL has changed -- One cannot continue to use it without changing helm repos. If you check the appVersion for the helm chart, you can see it's the same. Hence, nothing has changed in kured's code itself for that breaking change.

evrardjp commented 2 years ago

FYI, I just edited the checklist, ticked a few boxes :)

dholbach commented 2 years ago

This thread has a bunch of security recommendations. Some might be longer term material, some might be easy to integrate.

One tool that is mentioned in there to adhere to GitHub repo best-practices is https://github.com/ossf/allstar

dholbach commented 2 years ago

I enabled allstar for the entire org.

dholbach commented 1 year ago

I think we can close this now, right?

ckotzbauer commented 1 year ago

yes