search

kubereboot / kured

Kubernetes Reboot Daemon
https://kured.dev
Apache License 2.0
2.17k stars 202 forks source link

fix: make sure node is drained before rebooting when rebootDelay is g… #930

Open sebastiangaiser opened 4 months ago

sebastiangaiser commented 4 months ago

…reater than 0

closes #929

jackfrancis commented 4 months ago

I've added some concerns in the original issue #929. Let's definitely figure out how to solve for this scenario, but I'm not sure that a second drain operation after the retry wait is the right solution.

evrardjp commented 4 months ago

I like the idea, but I think we have details to iron out.

github-actions[bot] commented 2 months ago

This PR was automatically considered stale due to lack of activity. Please refresh it and/or join our slack channels to highlight it, before it automatically closes (in 7 days).

sebastiangaiser commented 2 months ago

Not stale...

evrardjp commented 1 month ago

@sebastiangaiser maybe we could have a meeting and you explain your point of view/what's missing to progress this? I like the concept.

sebastiangaiser commented 1 month ago

I'm sorry but I don't have the time, currently. Feel free to hijack/supersede my PR.