thematic inconsistent namespacing (theme review)

[GoogleCodeExporter]

for theme review themes are req'd to use a unique slug as a prefix for all 
custom function names, classes, public/global variables, database entries 
(theme options, post custom metadata, etc). recommended to use theme-slug as 
this unique slug.

i went through the extensions folder, and found the following functions (and 
classes) that do NOT begin with the thematic_ slug.  if this namespace thing 
applies to filters as well (does it?) then i will go back through and look for 
problem filters.  i can see why we ought to but at the same time, changing 
filter names is going to be a headache for people maintaining child themes, 
whereas most of these functions are only called by internal functions and 
aren't as likely to have been added/removed by the end user. 

===============

**dynamic-classes.php**
browser_class_names

**content-extesions.php**
more_text
list_bookmarks_args

**comments-extensions.php**
list_comments_arg

**header-extensions.php**
pageGetPageNo

**sidebar-extensions.php**
widget_area_primary_aside
widget_area_index_top
widget_area_index_insert
widget_area_index_bottom
widget_area_single_top
widget_area_single_insert
widget_area_single_bottom
widget_area_page_top
widget_area_page_bottom
widget_area_subsidiaries
add_between_firstsecond_sub
add_between_secondthird_sub
add_after_third_sub

**shortcodes.php**
thmfooter_wp_link
thmfooter_theme_link
thmfooter_login_link
thmfooter_blog_title
thmfooter_blog_link
thmfooter_year
theme_name
theme_author
theme_uri
theme_version
child_name
child_author
child_uri
child_version

**widgets.php**
classes//
  THM_Widget_Search
  THM_Widget_Meta
  THM_Widget_RSSlinks

functions//
  widget_thematic_rsslinks_control

Original issue reported on code.google.com by helgathe...@gmail.com on 26 Jan 2012 at 9:33

[GoogleCodeExporter]

r820 deals with sidebar-extensions.php and the widget calls in 
footer-extensions.php and the sidebar templates 

Original comment by eugene.m...@gmail.com on 31 Jan 2012 at 4:42

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

in r821 short codes are done

Original comment by eugene.m...@gmail.com on 31 Jan 2012 at 8:27

• Changed state: Started

[GoogleCodeExporter]

r823 finishes it...

* Changed: all of the fuunctions in shortcodes.php to namspace with
<code>thematic_*</code>
* Changed: <code>thematic_page_title()</code> to remove 'Blog Archives'
* Removed: <code>widget_thematic_rsslinks_control()</code>
* Changed: Namespacing of classes from <code>THM_*</code> to
<code>Thematic_*</code>
* Changed: Namespacing of functions from <code>widget_area_*()</code> to
<code>thematic_widget_area_*()</code>
* Deprecated: <code>widget_area_*()</code> functions
<code>list_bookmarks_args(), list_comments_arg(), pageGetPageNo()</code>

Whoever feels like it, please test to verify. Thanks!

Original comment by eugene.m...@gmail.com on 1 Feb 2012 at 1:46

• Changed state: Fixed