Closed cschieder closed 5 months ago
The design looks great.
Additionaly (this doesn't force the design change), when user creates a new custom image and choose a storage class for it, and later the user selects the custom image from drop down list the previously storage class should be set as a default (although users should be able to change it).
@sankalp-r please take a look as well and link the issues you worked on.
@shaase-ctrl I think we should make custom images feature ee only as well, what do you think? Then from KubeVirt side we would have two ee in context of disks:
also possibility to add custom images should be configurable over seed configuration.
We have decided to use custom images only as EE and that should not be visible on CE.
Information if we should show user custom images (the wizard and each view related) have to be read from seed configuration kubevirt.images.enableCustomImages: [true|false]
@Waseem826 I should be able to finish the API at the beginning of next week.
As discussed with @csengerszabo and @mfranczy we'll skip this issue from 2.22
release so I've updated the labels accordingly.
Design
Modal
On Page (Table and Dropdown)
On Page, Empty
Tasks
Custom Local Disks
toCustom Images
kubevirt.images.enableCustomImages
on seed config is set