search

kubermatic / dashboard

Dashboard For The Kubermatic Kubernetes Platform
https://www.kubermatic.com
Other
42 stars 61 forks source link

Add static labels option to the admin panel #6735

Closed ahmadhamzh closed 2 weeks ago

ahmadhamzh commented 2 months ago

What this PR does / why we need it: add static labels in the admin defaults page, these labels are only for clusters and can be used in the cluster creation wizard admin settings:

image

create cluster: image

edit cluster:

image

Which issue(s) this PR fixes: Fixes #6724

What type of PR is this? /kind feature

Special notes for your reviewer:

add new static labels option in admin settings.
TBD
ahmadhamzh commented 2 weeks ago

/retest

ahmadhamzh commented 2 weeks ago

/retest

ahmadhamzh commented 2 weeks ago

/retest

ahmadhamzh commented 2 weeks ago

/retest

ahmadhamzh commented 2 weeks ago

/retest

kubermatic-bot commented 2 weeks ago

LGTM label has been added.

Git tree hash: 5c6c07c5e7b66edcb85071b8e81472d310a0ed2a

Waseem826 commented 2 weeks ago

Approved from my side. @ahmedwaleedmalik do you have any feedback? If not please take a look at API changes and approve.

ahmadhamzh commented 2 weeks ago

/retest

ahmadhamzh commented 2 weeks ago

/retest

ahmadhamzh commented 2 weeks ago

/retest

ahmadhamzh commented 2 weeks ago

/retest

ahmadhamzh commented 2 weeks ago

/retest

kubermatic-bot commented 2 weeks ago

LGTM label has been added.

Git tree hash: 5edd0e521a88d025406d6ca3d1054d63426813e0

kubermatic-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[modules/api/OWNERS](https://github.com/kubermatic/dashboard/blob/main/modules/api/OWNERS)~~ [ahmedwaleedmalik] - ~~[modules/api/pkg/OWNERS](https://github.com/kubermatic/dashboard/blob/main/modules/api/pkg/OWNERS)~~ [ahmedwaleedmalik] - ~~[modules/api/pkg/api/OWNERS](https://github.com/kubermatic/dashboard/blob/main/modules/api/pkg/api/OWNERS)~~ [ahmedwaleedmalik] - ~~[modules/api/pkg/handler/OWNERS](https://github.com/kubermatic/dashboard/blob/main/modules/api/pkg/handler/OWNERS)~~ [ahmedwaleedmalik] - ~~[modules/web/src/OWNERS](https://github.com/kubermatic/dashboard/blob/main/modules/web/src/OWNERS)~~ [ahmedwaleedmalik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubermatic-triage-bot commented 2 weeks ago

/retest This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

kubermatic-triage-bot commented 2 weeks ago

/retest This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Waseem826 commented 2 weeks ago

/hold Please remove after tests are fixed.

ahmadhamzh commented 2 weeks ago

/retest

Waseem826 commented 2 weeks ago

/lgtm /unhold

kubermatic-bot commented 2 weeks ago

LGTM label has been added.

Git tree hash: fa21d7d15f26e35d67860524a1a64255f7939ef1