search

kubermatic / dashboard

Dashboard For The Kubermatic Kubernetes Platform
https://www.kubermatic.com
Other
42 stars 61 forks source link

Fix the pagination in project members table #6741

Closed ahmadhamzh closed 1 month ago

ahmadhamzh commented 1 month ago

What this PR does / why we need it: fix the pagination for the project member table

member page: image Which issue(s) this PR fixes: Fixes #6737

What type of PR is this? /kind bug /kind cleanup

Fix the pagination in project members table.
NONE
ahmedwaleedmalik commented 1 month ago

Please add a release note.

ahmadhamzh commented 1 month ago

/retest

ahmadhamzh commented 1 month ago

/retest

ahmadhamzh commented 1 month ago

/test pre-dashboard-web-integration-tests-ce

kubermatic-bot commented 1 month ago

LGTM label has been added.

Git tree hash: 7eade123cce059671bb17cf7fd978fa09aed75cc

kubermatic-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[modules/web/src/OWNERS](https://github.com/kubermatic/dashboard/blob/main/modules/web/src/OWNERS)~~ [ahmedwaleedmalik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ahmedwaleedmalik commented 1 month ago

/cherry-pick release/v2.25

kubermatic-bot commented 1 month ago

@ahmedwaleedmalik: once the present PR merges, I will cherry-pick it on top of release/v2.25 in a new PR and assign it to you.

In response to [this](https://github.com/kubermatic/dashboard/pull/6741#issuecomment-2238860487): >/cherry-pick release/v2.25 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ahmedwaleedmalik commented 1 month ago

/cherry-pick release/v2.24

kubermatic-bot commented 1 month ago

@ahmedwaleedmalik: once the present PR merges, I will cherry-pick it on top of release/v2.24 in a new PR and assign it to you.

In response to [this](https://github.com/kubermatic/dashboard/pull/6741#issuecomment-2238860591): >/cherry-pick release/v2.24 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ahmedwaleedmalik commented 1 month ago

/cherry-pick release/v2.23

kubermatic-bot commented 1 month ago

@ahmedwaleedmalik: once the present PR merges, I will cherry-pick it on top of release/v2.23 in a new PR and assign it to you.

In response to [this](https://github.com/kubermatic/dashboard/pull/6741#issuecomment-2238860693): >/cherry-pick release/v2.23 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubermatic-bot commented 1 month ago

@ahmedwaleedmalik: #6741 failed to apply on top of branch "release/v2.23":

Applying: fix the paginator in project members table
Using index info to reconstruct a base tree...
M   modules/web/src/app/member/component.ts
Falling back to patching base and 3-way merge...
Auto-merging modules/web/src/app/member/component.ts
CONFLICT (content): Merge conflict in modules/web/src/app/member/component.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix the paginator in project members table
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubermatic/dashboard/pull/6741#issuecomment-2238860693): >/cherry-pick release/v2.23 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubermatic-bot commented 1 month ago

@ahmedwaleedmalik: #6741 failed to apply on top of branch "release/v2.25":

Applying: fix the paginator in project members table
Using index info to reconstruct a base tree...
M   modules/web/src/app/member/component.ts
Falling back to patching base and 3-way merge...
Auto-merging modules/web/src/app/member/component.ts
CONFLICT (content): Merge conflict in modules/web/src/app/member/component.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix the paginator in project members table
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubermatic/dashboard/pull/6741#issuecomment-2238860487): >/cherry-pick release/v2.25 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubermatic-bot commented 1 month ago

@ahmedwaleedmalik: #6741 failed to apply on top of branch "release/v2.24":

Applying: fix the paginator in project members table
Using index info to reconstruct a base tree...
M   modules/web/src/app/member/component.ts
Falling back to patching base and 3-way merge...
Auto-merging modules/web/src/app/member/component.ts
CONFLICT (content): Merge conflict in modules/web/src/app/member/component.ts
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix the paginator in project members table
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubermatic/dashboard/pull/6741#issuecomment-2238860591): >/cherry-pick release/v2.24 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.