search

kubermatic / dashboard

Dashboard For The Kubermatic Kubernetes Platform
https://www.kubermatic.com
Other
42 stars 62 forks source link

fetch seed's CA bundle before connecting with metering Minio #6752

Closed xrstf closed 2 months ago

xrstf commented 3 months ago

What this PR does / why we need it: This PR ensures that the API will fetch the CA bundle on the target seed in order to securely connect to the metering obect store. KKP's operator copies the CA bundle onto ever seed, because it is meant to potentially deviate per seed, so this patch purposefully does not use the CA bundle the API loaded on startup (via --ca-bundle), but fetches it from the seed instead.

Which issue(s) this PR fixes: Fixes #6751

What type of PR is this? /kind bug

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix TLS errors in the admin page when using a custom CA for the metering object store.

Documentation:

NONE
kubermatic-bot commented 2 months ago

LGTM label has been added.

Git tree hash: 549caab3c8ad92cdb5036fd6d2fa8db19d9163de

kubermatic-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[modules/api/pkg/OWNERS](https://github.com/kubermatic/dashboard/blob/main/modules/api/pkg/OWNERS)~~ [ahmedwaleedmalik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dharapvj commented 2 months ago

/cherrypick release/v2.25

kubermatic-bot commented 2 months ago

@dharapvj: new pull request created: #6760

In response to [this](https://github.com/kubermatic/dashboard/pull/6752#issuecomment-2268350999): >/cherrypick release/v2.25 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.