kubermatic / dashboard

Dashboard For The Kubermatic Kubernetes Platform
https://www.kubermatic.com
Other
42 stars 62 forks source link

Use APIServerExternalAddress from cluster status in Kubeconfigs shared/downladed via dashboard #6759

Closed ahmedwaleedmalik closed 2 months ago

ahmedwaleedmalik commented 2 months ago

What this PR does / why we need it: Follow up of https://github.com/kubermatic/kubermatic/pull/13562; this adds a special case where if the APIServerExternalAddress exists in the Cluster status then it's going to be used for all the kubeconfigs that can be downloaded via the dashboard.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE
kubermatic-bot commented 2 months ago

LGTM label has been added.

Git tree hash: 5211d8780b4e539aeb45faad5e72cd4f2cfa432f

kubermatic-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[modules/api/OWNERS](https://github.com/kubermatic/dashboard/blob/main/modules/api/OWNERS)~~ [Waseem826] - ~~[modules/api/pkg/OWNERS](https://github.com/kubermatic/dashboard/blob/main/modules/api/pkg/OWNERS)~~ [Waseem826] - ~~[modules/api/pkg/handler/OWNERS](https://github.com/kubermatic/dashboard/blob/main/modules/api/pkg/handler/OWNERS)~~ [Waseem826] - ~~[modules/api/pkg/provider/kubernetes/OWNERS](https://github.com/kubermatic/dashboard/blob/main/modules/api/pkg/provider/kubernetes/OWNERS)~~ [Waseem826] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment