kubermatic-bot
commented
2 months ago [APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Waseem826
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
- ~~[modules/api/OWNERS](https://github.com/kubermatic/dashboard/blob/main/modules/api/OWNERS)~~ [Waseem826]
- ~~[modules/api/pkg/OWNERS](https://github.com/kubermatic/dashboard/blob/main/modules/api/pkg/OWNERS)~~ [Waseem826]
- ~~[modules/api/pkg/api/OWNERS](https://github.com/kubermatic/dashboard/blob/main/modules/api/pkg/api/OWNERS)~~ [Waseem826]
- ~~[modules/api/pkg/handler/OWNERS](https://github.com/kubermatic/dashboard/blob/main/modules/api/pkg/handler/OWNERS)~~ [Waseem826]
- ~~[modules/web/src/OWNERS](https://github.com/kubermatic/dashboard/blob/main/modules/web/src/OWNERS)~~ [Waseem826]
Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
What this PR does / why we need it: Exposing the option to specify VM Group for vSphere machines that was introduced in https://github.com/kubermatic/machine-controller/issues/1846, on the UI and API side.
Which issue(s) this PR fixes:
xref https://github.com/kubermatic/machine-controller/issues/1846
What type of PR is this?
/kind feature Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: