kubermatic / dashboard

Dashboard For The Kubermatic Kubernetes Platform
https://www.kubermatic.com
Other
42 stars 62 forks source link

Some spacing in the advanced network configuration of the cluster creation wizard is misleading #6860

Open judge-red opened 1 day ago

judge-red commented 1 day ago

What is the problem, where is it and why is it an issue?

In step 2 (Cluster) of the cluster creation wizard: The Ingress checkbox has nothing to do with the textbox just below it, and the Edit CNI Values button has nothing to do with the checkboxes underneath it. But imho the UI suggests such a connection because it groups these things closer than other items.

image image

Also, enabling the Ingress checkbox actually does change the CNI values, so it should probably be relocated to the Edit CNI Values button (and in this case, the smaller gap between the two would make sense, imho).

Suggest how to fix it, if possible

I get that most checkboxes have less margin/padding than textboxes, and e.g. here I think that's good:

image

But the checkboxes mentioned above should rather use this spacing (found in step 3, Settings, probably only shown with the OpenStack provider):

image
ahmedwaleedmalik commented 1 day ago

Tentatively adding this to KKP 2.26 milestone since these are UI/UX issues; it'd be nice if we can fix them in 2.26 but since we are in code freeze this might not make it to 2.26.

/milestone KKP 2.26