search

kubermatic / docs

Documentation for Kubermatic projects
https://docs.kubermatic.com/
Other
15 stars 105 forks source link

Update default applications docs as per 2.25 changes #1631

Closed archups closed 5 months ago

archups commented 6 months ago

Updated images of the default applications to reflect logo, documentlink and sourcecodelink. Related to https://github.com/kubermatic/kubermatic/pull/13054

archups commented 6 months ago

/cc @xrstf

xrstf commented 6 months ago

I tink img/common/ was to express "these pictures are used across many products/versions". To add a 2.24 directory within the common directory is kind of ... the opposite of what the directory structure was meant to be... So what's the plan now? To have KKP2.24-specific files in img/common/? What does "common" then mean?

archups commented 6 months ago

I tink img/common/ was to express "these pictures are used across many products/versions". To add a 2.24 directory within the common directory is kind of ... the opposite of what the directory structure was meant to be... So what's the plan now? To have KKP2.24-specific files in img/common/? What does "common" then mean?

@xrstf makes sense. Moved the 2.24 specific images to respective directory now. Thanks!

kubermatic-bot commented 5 months ago

LGTM label has been added.

Git tree hash: 1ce286a5fd35f39ba49920bd08a33c1d8a1508ad

kubermatic-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubermatic/docs/blob/master/OWNERS)~~ [embik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment