Closed koksay closed 7 months ago
@embik I believe I covered all the items except --anonymous-auth
parameter setting. To be honest, I have no idea why we don't set it at all (other than it does not cause issues because or our RBAC settings)
@embik I believe I covered all the items except
--anonymous-auth
parameter setting. To be honest, I have no idea why we don't set it at all (other than it does not cause issues because or our RBAC settings)
I think this document will need another review from @xmudrii and @kron4eg to figure out things like that.
@xmudrii Thanks again for the review. I updated the document based on your feedback.
I also added my doc generation python script to the hack
directory, so it would be used later.
@xmudrii I put it on the main
documentation, should it also be under 1.7
?
@koksay Adding it to 1.7 makes sense, do you want to do that before we merge this PR?
LGTM label has been added.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: xmudrii
The full list of commands accepted by this bot can be found here.
The pull request process is described here
This PR adds CIS Benchmark 1.8 documentation for KubeOne 1.7.3 and Kubernetes 1.27.
It especially requires a review for:
Details
section forNot Applicable
controlsWarn
andFail
controls, if they should be changed toNot Applicable