search

kubermatic / docs

Documentation for Kubermatic projects
https://docs.kubermatic.com/
Other
16 stars 106 forks source link

Move the images near to the content #1710

Closed archups closed 3 months ago

archups commented 3 months ago

This PR is to move the images near to the content. related to restructuring of the images rendering https://github.com/kubermatic/docs/pull/1654 Plus some cleanup of the images that are not used/redundant or are from previous version in the main branch. Plus few broken images link fixes. Also, updated few images.

embik commented 3 months ago

@xrstf can you PTAL to ensure we do images the way it is supposed to be?

xrstf commented 3 months ago

No, this is specifically not what we want to do. The whole idea behind the @ syntax is that you as the content author do NOT have to add :./../../../../../../../../../ to your image paths.

archups commented 3 months ago

No, this is specifically not what we want to do. The whole idea behind the @ syntax is that you as the content author do NOT have to add :./../../../../../../../../../ to your image paths.

Thanks @xrstf for the feedback. Can you please verify once as I have rebased to pull the changes from #1711 to resolve conflicts too and is what we are looking for as part of the restructuring change - moving the images closer to the content If this is correct change, then I will proceed with remaining changes. Thanks for reviewing it again!

archups commented 3 months ago

@xrstf All the changes are pushed as well now including for the review comments. Ready for review. Thanks!

xrstf commented 3 months ago

/approve /lgtm

kubermatic-bot commented 3 months ago

LGTM label has been added.

Git tree hash: b4907857f841c4b07a684689de966504d27467ee

kubermatic-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubermatic/docs/blob/main/OWNERS)~~ [xrstf] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment