kubermatic / kubecarrier

KubeCarrier - Service Management at Scale
Apache License 2.0
297 stars 14 forks source link

Instance service auth #483

Closed aborilov closed 4 years ago

aborilov commented 4 years ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #472

Special notes for your reviewer:

Documentation:

Does this PR introduce a user-facing change?:

NONE
kubermatic-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aborilov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubermatic/kubecarrier/blob/feature-api-server/OWNERS)~~ [aborilov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubermatic-bot commented 4 years ago

LGTM label has been added.

Git tree hash: b4a2e7ff097d8cb20ddf57ee88c8a00e000b5ad7

thetechnick commented 4 years ago

/retest

thetechnick commented 4 years ago

/retest

kubermatic-triage-bot commented 4 years ago

/retest This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat. /meow

kubermatic-bot commented 4 years ago

@kubermatic-triage-bot: cat image

In response to [this](https://github.com/kubermatic/kubecarrier/pull/483#issuecomment-646053270): >/retest >This bot automatically retries jobs that failed/flaked on approved PRs > >Review the [full test history](https://prow.loodse.com/pr-history/?org=kubermatic&repo=kubecarrier&pr=483) > >Silence the bot with an `/lgtm cancel` or `/hold` comment for consistent failures. > >Also, here is a cat. >/meow Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
aborilov commented 4 years ago

/hold

kubermatic-bot commented 4 years ago

@aborilov: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubecarrier-e2e-v1.16 06a87d81d0342bed5120d35414ccb299288dc3dc link /test pull-kubecarrier-e2e-v1.16

Full PR test history

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).