search

kubermatic / kubecarrier

KubeCarrier - Service Management at Scale
Apache License 2.0
297 stars 14 forks source link

Removed unnecessary logging #509

Closed nmiculinic closed 4 years ago

nmiculinic commented 4 years ago

What this PR does / why we need it: It removes rendundant logging. Due to gRPC logging middleware, it shall handle the proper request logging, together with the returned status code. 

NONE
kubermatic-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nmiculinic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubermatic/kubecarrier/blob/master/OWNERS)~~ [nmiculinic] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubermatic-bot commented 4 years ago

LGTM label has been added.

Git tree hash: 46836fc116354ed5aa896d8875bfa4183decbc62

kubermatic-triage-bot commented 4 years ago

/retest This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat. /meow

kubermatic-bot commented 4 years ago

@kubermatic-triage-bot: cat image

In response to [this](https://github.com/kubermatic/kubecarrier/pull/509#issuecomment-659369054): >/retest >This bot automatically retries jobs that failed/flaked on approved PRs > >Review the [full test history](https://prow.loodse.com/pr-history/?org=kubermatic&repo=kubecarrier&pr=509) > >Silence the bot with an `/lgtm cancel` or `/hold` comment for consistent failures. > >Also, here is a cat. >/meow Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kubermatic-triage-bot commented 4 years ago

/retest This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat. /meow

kubermatic-bot commented 4 years ago

@kubermatic-triage-bot: cat image

In response to [this](https://github.com/kubermatic/kubecarrier/pull/509#issuecomment-659414460): >/retest >This bot automatically retries jobs that failed/flaked on approved PRs > >Review the [full test history](https://prow.loodse.com/pr-history/?org=kubermatic&repo=kubecarrier&pr=509) > >Silence the bot with an `/lgtm cancel` or `/hold` comment for consistent failures. > >Also, here is a cat. >/meow Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kubermatic-triage-bot commented 4 years ago

/retest This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat. /meow

kubermatic-bot commented 4 years ago

@kubermatic-triage-bot: cat image

In response to [this](https://github.com/kubermatic/kubecarrier/pull/509#issuecomment-659467362): >/retest >This bot automatically retries jobs that failed/flaked on approved PRs > >Review the [full test history](https://prow.loodse.com/pr-history/?org=kubermatic&repo=kubecarrier&pr=509) > >Silence the bot with an `/lgtm cancel` or `/hold` comment for consistent failures. > >Also, here is a cat. >/meow Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kubermatic-triage-bot commented 4 years ago

/retest This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat. /meow

kubermatic-bot commented 4 years ago

@kubermatic-triage-bot: cat image

In response to [this](https://github.com/kubermatic/kubecarrier/pull/509#issuecomment-659520624): >/retest >This bot automatically retries jobs that failed/flaked on approved PRs > >Review the [full test history](https://prow.loodse.com/pr-history/?org=kubermatic&repo=kubecarrier&pr=509) > >Silence the bot with an `/lgtm cancel` or `/hold` comment for consistent failures. > >Also, here is a cat. >/meow Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.