Fix customResourceDiscoverySet controller

kubermatic / kubecarrier

KubeCarrier - Service Management at Scale

Apache License 2.0

297 stars 14 forks source link

Fix customResourceDiscoverySet controller #514

Closed nmiculinic closed 4 years ago

nmiculinic commented 4 years ago

What this PR does / why we need it:

This PR fixed the customResourceDiscoverySet Bug. The bug is as follows:

2 provides use the same-named CustomResourceDiscoverySet
The // Cleanup uncontrolled CRDiscoveries which was intended to clean up CRDiscoveries for deleted service clusters assassinates other providers CRDiscoveries. Why? Because the lookup isn't namespace bound but crosses the namespace boundary.

This PR fixes this in 2 ways, for extra safety:

the lookup is now namespace bound
the label value is now namespace aware

NONE

kubermatic-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nmiculinic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubermatic/kubecarrier/blob/master/OWNERS)~~ [nmiculinic] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

nmiculinic commented 4 years ago

/retest

nmiculinic commented 4 years ago

/retest

nmiculinic commented 4 years ago

/retest

aborilov commented 4 years ago

/lgtm

kubermatic-bot commented 4 years ago

LGTM label has been added.

Git tree hash: e3d7b97f3e2f8ba04224aa295f38483b1faff7b0