search

kubermatic / kubecarrier

KubeCarrier - Service Management at Scale
Apache License 2.0
297 stars 14 forks source link

Replace sudo chown with --user flag in docker #519

Closed jiachengxu closed 4 years ago

jiachengxu commented 4 years ago

What this PR does / why we need it: This PR replaces sudo chown with --user flag in docker.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Documentation:

Does this PR introduce a user-facing change?:

NONE
kubermatic-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiachengxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubermatic/kubecarrier/blob/master/OWNERS)~~ [jiachengxu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jiachengxu commented 4 years ago

@neven Can you please confirm if this works on Linux?

nmiculinic commented 4 years ago

/lgtm

works for me!

kubermatic-bot commented 4 years ago

LGTM label has been added.

Git tree hash: c6aca7866881ec2c101343f09b631ff30e1cbb07

jiachengxu commented 4 years ago

/retest

jiachengxu commented 4 years ago

/retest