kubermatic / kubecarrier

KubeCarrier - Service Management at Scale
Apache License 2.0
297 stars 14 forks source link

Add common labels to service selector, to avoid service endpoint overlap #525

Closed thetechnick closed 4 years ago

thetechnick commented 4 years ago

What this PR does / why we need it: When registering multiple CRDs in the same namespace the webhook selector will mach all elevator/catapult instances, do round robin load balancing and lead to this error:

Error from server (InternalError): error when creating "./master_cluster/kubecarrier/services/cert-svc1-tenant1.yaml": Internal error occurred: failed calling webhook "mcertificate.kubecarrier.io": Post https://certificates-svc-1-catapult-webhook-service.provider-1.svc:443/mutate-svc-1-provider-1-v1alpha2-certificate?timeout=30s: x509: certificate is valid for certificates-svc-2-catapult-webhook-service.provider-1.svc, certificates-svc-2-catapult-webhook-service.provider-1.svc.cluster.local, not certificates-svc-1-catapult-webhook-service.provider-1.svc

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Documentation:

Does this PR introduce a user-facing change?:

NONE
kubermatic-bot commented 4 years ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

kubermatic-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thetechnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubermatic/kubecarrier/blob/master/OWNERS)~~ [thetechnick] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
thetechnick commented 4 years ago

/test all

thetechnick commented 4 years ago

/retest

nmiculinic commented 4 years ago

/lgtm

jiachengxu commented 4 years ago

/hold

kubermatic-bot commented 4 years ago

LGTM label has been added.

Git tree hash: 214efd826cead76d2d5bbf1194fa0f2fa26f5a76

jiachengxu commented 4 years ago

/unhold

thetechnick commented 4 years ago

/retest

kubermatic-triage-bot commented 4 years ago

/retest This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat. /meow

kubermatic-bot commented 4 years ago

@kubermatic-triage-bot: cat image

In response to [this](https://github.com/kubermatic/kubecarrier/pull/525#issuecomment-665692376): >/retest >This bot automatically retries jobs that failed/flaked on approved PRs > >Review the [full test history](https://prow.loodse.com/pr-history/?org=kubermatic&repo=kubecarrier&pr=525) > >Silence the bot with an `/lgtm cancel` or `/hold` comment for consistent failures. > >Also, here is a cat. >/meow Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
thetechnick commented 4 years ago

/retest