search

kubermatic / kubecarrier

KubeCarrier - Service Management at Scale
Apache License 2.0
297 stars 14 forks source link

add crd version storage flag #526

Closed aborilov closed 4 years ago

aborilov commented 4 years ago

What this PR does / why we need it: Added CRD Version storage flag to offering objects

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #524

Special notes for your reviewer:

Documentation:

Does this PR introduce a user-facing change?:

CRDVersion `storage` flag added
kubermatic-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aborilov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubermatic/kubecarrier/blob/master/OWNERS)~~ [aborilov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
aborilov commented 4 years ago

Can you please add a small unit test for catalogEntry to make sure the value is propagated?

done

aborilov commented 4 years ago

Overall it looks good to me; could you also check for this behaviour in some e2e test?

done

aborilov commented 4 years ago

/retest

kubermatic-bot commented 4 years ago

LGTM label has been added.

Git tree hash: d291a7f6f2afa421f1d4754cc38bebd36608f33f

aborilov commented 4 years ago

/retest

aborilov commented 4 years ago

/retest

aborilov commented 4 years ago

/retest