Deprecate KindOverride fields and use internal api group.

kubermatic / kubecarrier

KubeCarrier - Service Management at Scale

Apache License 2.0

297 stars 14 forks source link

Deprecate KindOverride fields and use internal api group. #531

Closed jiachengxu closed 4 years ago

jiachengxu commented 4 years ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Documentation:

Does this PR introduce a user-facing change?:

Deprecate KindOverride fields and use internal api group.

kubermatic-bot commented 4 years ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

kubermatic-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiachengxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubermatic/kubecarrier/blob/master/OWNERS)~~ [jiachengxu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

jiachengxu commented 4 years ago

/retest

jiachengxu commented 4 years ago

/retest

jiachengxu commented 4 years ago

/retest

aborilov commented 4 years ago

/lgtm

kubermatic-bot commented 4 years ago

LGTM label has been added.

Git tree hash: b14fdcff9d074537f6db0b2d9d8f126f8804d1d8

jiachengxu commented 4 years ago

/hold

jiachengxu commented 4 years ago

/retest

jiachengxu commented 4 years ago

/unhold

thetechnick commented 4 years ago

/lgtm

kubermatic-bot commented 4 years ago

LGTM label has been added.

Git tree hash: 236dbc7b1dd4678585878a4685b53098e8c2f01c