search

kubermatic / machine-controller

Apache License 2.0
306 stars 125 forks source link

Too many reconciliation errors/warnings for machine deployment objects #1775

Closed akash-gautam closed 1 month ago

akash-gautam commented 6 months ago

When we create or update machine deployments there are many errors/warnings saying operations can't be fulfilled because the object has been modified, which I think happens due to resource version changes when concurrent updates happen to the machine deployment object. A support request was raised mentioning that we should try to improve this as this can confuse the admins on whether deployment is successful or not or if they made any error on their part. 

Warning ReconcileError 2m9s (x3 over 2m9s) machinedeployment-controller Operation cannot be fulfilled on machinedeployments.cluster.k8s.io "kkp-tst-root-pool1": the object has been modified; please apply your changes to the latest version and try again

"The error message doesn't necessitate a failure, however it is the same message whether the deployment succeeds or fails, which makes it difficult to monitor, causing me to manually check up on any all deployments. I would say it is very much a low priority, more a quality of life issue."

More details on #INC-6541

kubermatic-bot commented 3 months ago

Issues go stale after 90d of inactivity. After a furter 30 days, they will turn rotten. Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubermatic-bot commented 2 months ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kubermatic-bot commented 1 month ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

kubermatic-bot commented 1 month ago

@kubermatic-bot: Closing this issue.

In response to [this](https://github.com/kubermatic/machine-controller/issues/1775#issuecomment-2332942222): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.