kubermatic / machine-controller

Apache License 2.0
309 stars 131 forks source link

Future API group conflict with upstream CAPI #1780

Open schlakob opened 7 months ago

schlakob commented 7 months ago

Hi,

we are currently using the machine-controller as an addon of Kubeone, in its default configuration.

I was wondering why the CRDs of CAPI (machinedeployments, machinesets, machines) are of the cluster.k8s.io api group and not of the upstream CAPI cluster.x-k8s.io api group? I noticed, that CAPI switched from k8s.io to x-k8s.io a while ago.

Are there plans using the same api group as upstream CAPI in future?

For us this is important, because we are thinking of deploying a CAPI in the Kubeone cluster running the machine-controller, therefore we would like to ensure, that no conflicts regarding the CRDs occur.

kron4eg commented 7 months ago

Hello. Because up until now we preferred to stay on older CAPI (v1alpha1) version. The rumors say maybe we want to update, but that's not currently on the table.

schlakob commented 7 months ago

This would then result in conflicts when running a CAPI and machine-controller in the same cluster. Is or will there be a way to overwrite the group for the machine-controller.

embik commented 5 months ago

If the Kubermatic stack ever upgrades to newer CAPI versions and adopts newer API groups, it would probably integrate into CAPI as a set of providers. I don't think this would really create a conflict since CAPI is pluggable by design.

kubermatic-bot commented 2 months ago

Issues go stale after 90d of inactivity. After a furter 30 days, they will turn rotten. Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubermatic-bot commented 1 month ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kubermatic-bot commented 1 week ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

kubermatic-bot commented 1 week ago

@kubermatic-bot: Closing this issue.

In response to [this](https://github.com/kubermatic/machine-controller/issues/1780#issuecomment-2496447468): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kron4eg commented 1 week ago

/reopen

kubermatic-bot commented 1 week ago

@kron4eg: Reopened this issue.

In response to [this](https://github.com/kubermatic/machine-controller/issues/1780#issuecomment-2497309862): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.